vsk added inline comments.
================ Comment at: test/CodeGen/builtins-overflow.c:402 + int result; + if (__builtin_mul_overflow(y, x, &result)) + return LongLongErrorCode; ---------------- efriedma wrote: > I think the rules for __builtin_mul_overflow say you have to check whether > the truncate changes the value of the result. > > Missing testcases for the case where the result is unsigned. Thanks for the catch. I've updated my test driver to catch cases like this. https://reviews.llvm.org/D41149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
