mclow.lists added a comment. This looks good to me; with a couple of nits.
================ Comment at: test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp:26 + { + assert(this->eback() == 0); + assert(this->gptr() == 0); ---------------- Not zero, please. `nullptr` or `NULL` . `nullptr` would be better, but we can't assume c++11 here, so I guess it's `NULL`. https://reviews.llvm.org/D40707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits