vsk added a comment. I backed out the part of this patch which deals with array parameters declared like p[10] or p[static 10]: r320185.
================ Comment at: lib/CodeGen/CGExpr.cpp:833 + // Arrays don't have pass_object_size attributes, but if they have a constant + // size modifier it's the array size (C99 6.5.7.2p1). + if (auto *DecayedArrayTy = dyn_cast<DecayedType>(ParamDecl->getType())) ---------------- efriedma wrote: > "int f(int a[10])" might look like an array, but it isn't: it's just a > different syntax to declare a pointer. So it's legal to "lie" in the > signature. (If you want to actually pass a pointer to an array, you have to > write "int (*a)[10]".) And the definition of "static" says "an array with at > least as many elements as specified by the size expression", which isn't a > maximum, so that doesn't really help either. > > Most people would consider it bad style to put a number into the array bound > which doesn't reflect reality, but I think we shouldn't try to check it > unless the user explicitly requests it. My copy of the C99 draft (n1256) is a little fuzzy on this point [*]. There's enough of a gray area here that it seems appropriate to back out this part of the patch. * It states: "In addition to optional type qualifiers and the keyword static, the [ and ] may delimit an expression or *. If they delimit an expression (which specifies the size of an array) ...". I took the parenthetical literally, and didn't know about the 'at least as many' language. https://reviews.llvm.org/D40940 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
