[PATCH] D40929: Unblock Swift Calling Convention Mangling on Windows

[Thomas Roughton via Phabricator via cfe-commits]

troughton updated this revision to Diff 125847.
troughton added a comment.

Add back a mistakenly removed default case.


Repository:
  rC Clang

https://reviews.llvm.org/D40929

Files:
  lib/AST/MicrosoftMangle.cpp


Index: lib/AST/MicrosoftMangle.cpp
===================================================================
--- lib/AST/MicrosoftMangle.cpp
+++ lib/AST/MicrosoftMangle.cpp
@@ -2131,9 +2131,12 @@

   switch (CC) {
     default:
-      llvm_unreachable("Unsupported CC for mangling");
+      llvm::errs() << "Unsupported CC for mangling" << CC << ".\n";
     case CC_Win64:
     case CC_X86_64SysV:
+    // NOTE: SwiftCC should have its own mangling specifier.
+    // For now, don't do anything special and treat SwiftCC like __cdecl.
+    case CC_Swift:
     case CC_C: Out << 'A'; break;
     case CC_X86Pascal: Out << 'C'; break;
     case CC_X86ThisCall: Out << 'E'; break;



Index: lib/AST/MicrosoftMangle.cpp
===================================================================
--- lib/AST/MicrosoftMangle.cpp
+++ lib/AST/MicrosoftMangle.cpp
@@ -2131,9 +2131,12 @@

   switch (CC) {
     default:
-      llvm_unreachable("Unsupported CC for mangling");
+      llvm::errs() << "Unsupported CC for mangling" << CC << ".\n";
     case CC_Win64:
     case CC_X86_64SysV:
+    // NOTE: SwiftCC should have its own mangling specifier.
+    // For now, don't do anything special and treat SwiftCC like __cdecl.
+    case CC_Swift:
     case CC_C: Out << 'A'; break;
     case CC_X86Pascal: Out << 'C'; break;
     case CC_X86ThisCall: Out << 'E'; break;

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits