hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clangd/CodeComplete.h:10 +// +// Code completion provides suggestions for what the user might type next. +// After "std::string S; S." we might suggest members of std::string. ---------------- nit: I prefer to put this comment below (near a class or function) to make it more obvious :) -- the same to other places. ================ Comment at: clangd/CodeComplete.h:80 +} // namespace clangd +} // namespace clang +#endif ---------------- nit: a blank line. ================ Comment at: clangd/Compiler.h:16 +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_COMPILER_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_COMPILER_H +#include "clang/Frontend/CompilerInstance.h" ---------------- nit : a blank line. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40719 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
