alexfh marked 2 inline comments as done.
alexfh added inline comments.
================
Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33
+#include "../performance/MoveConstArgCheck.h"
+#include "../performance/NoexceptMoveConstructorCheck.h"
#include "../readability/BracesAroundStatementsCheck.h"
----------------
xazax.hun wrote:
> Don't you need to add performance module to link to the HICPP module to avoid
> link errors?
Indeed. I should probably teach the script to do this ;)
================
Comment at: clang-tidy/performance/MoveConstArgCheck.h:19
-class MoveConstantArgumentCheck : public ClangTidyCheck {
+class MoveConstArgCheck : public ClangTidyCheck {
public:
----------------
xazax.hun wrote:
> Is there any specific reason to rename this class? I am ok with the change,
> just wondering.
The reason is to make the class name consistent with the check name (which is
the case for all checks added by the add_new_check script, but not the case for
some checks that predate this script).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40507
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
