=?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
AaronBallman wrote: > /cc @AaronBallman for `getCustomDiagID` I think it's fine to use `getCustomDiagID()` for this; it's not really a user-facing part of the compiler, so nobody is going to expect to localize diagnostics for it, etc. If we didn't already need a diagnostics engine for loading the AST file, I suspect we'd just use `llvm::errs()` to report diagnostics and would be fine with that. https://github.com/llvm/llvm-project/pull/222010 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
