ioeric added a comment.
Code looks good. Just some nits.
================
Comment at: clangd/JSONExpr.h:62
+// Array and Object also have typed indexing accessors for easy traversal:
+// if (json::obj* Opts = O.array("options"))
+// if (Optional<StringRef> Font = Opts->string("font"))
----------------
It's not obvious what `O.array("options")` does. Does it convert
`O.at("options")` to an array?
================
Comment at: clangd/JSONExpr.h:78
public:
- class Object;
+ enum Kind {
+ Null,
----------------
I wonder if we could merge `Kind` and `ExprType`.
https://reviews.llvm.org/D40182
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
