================
@@ -15,31 +15,41 @@
 #include "clang/AST/ExprObjC.h"
 #include "clang/AST/StmtVisitor.h"
 #include <optional>
+#include <utility>
 
 namespace clang {
 
 bool isSafePtr(clang::CXXRecordDecl *Decl) {
   return isRefCounted(Decl) || isCheckedPtr(Decl);
 }
 
-bool tryToFindPtrOrigin(
+static bool tryToFindPtrOriginImpl(
     const Expr *E, bool StopAtFirstRefCountedObj,
     std::function<bool(const clang::CXXRecordDecl *)> isSafePtr,
     std::function<bool(const clang::QualType)> isSafePtrType,
     std::function<bool(const clang::Decl *)> isSafeGlobalDecl,
-    std::function<bool(const clang::Expr *, bool)> callback) {
+    std::function<bool(const clang::Expr *, bool /*IsSafe*/,
+                       bool /*CrossedShortLivedTemporary*/)>
----------------
rniwa wrote:

I'm not sure "crossed short-lived temporary" is a very descriptive phrase.
Maybe we can say something like "IsFullExpressionTemporary" to make it more 
clear about the duration / semantics?

https://github.com/llvm/llvm-project/pull/224877
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to