mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM with comment added but if a different approach will be required for
multiple Linux targets (which we all treat as "hostish") then it's worth at
least thinking about that now.
================
Comment at: cmake/caches/Fuchsia-stage2.cmake:44
+set(LIBUNWIND_ENABLE_SHARED OFF CACHE BOOL "")
+set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "")
----------------
It's not completely obvious (to me) that these apply to the "default target"
build but not to the other LLVM_RUNTIME_TARGETS builds.
A comment here would be good.
We recently discussed enabling other *-linux targets (AFAIK we might as well
enable {x86_64,aarch64}-linux regardless of host, even for Mac hosts). We'd
want these settings for those too. Would that have to be done differently than
thsi?
Repository:
rL LLVM
https://reviews.llvm.org/D39930
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
