aaron.ballman added reviewers: rsmith, aaron.ballman.
aaron.ballman added a comment.
I think the new wording is a bit more clear, in general.
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize object parameter of type %0 with an expression "
+ "of type %1">;
----------------
I don't think this diagnostic needs to be moved and renamed; the old name was
more clear than "other" on the new name.
================
Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24
+ void lvalue() &; // expected-note 2 {{'lvalue' declared here}}
+ void const_lvalue() const&;
+ void rvalue() &&; // expected-note {{'rvalue' declared here}}
----------------
Can you add examples that cover the other diagnostic wordings as well
(volatile, restrict, combinations, etc)?
https://reviews.llvm.org/D39937
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
