krasimir added inline comments.
================
Comment at: lib/Format/ContinuationIndenter.cpp:1517
ReflowInProgress = SplitBefore.first != StringRef::npos;
+ DEBUG(if (ReflowInProgress) llvm::dbgs() << " Reflowing.\n");
TailOffset =
----------------
I'd rather
```
DEBUG({
if (ReflowInProgress)
llvm::dbgs() << " Reflowing.\n";
});
```
================
Comment at: unittests/Format/FormatTest.cpp:8007
+ " \"aaabbbcc ddde \"\n"
+ " \"efff\");",
format("someFunction(\"aaabbbcc ddde efff\");",
----------------
Why did the string got on a newline here?
================
Comment at: unittests/Format/FormatTestComments.cpp:2447
" a);",
- format("a = f(/* long long */ a);", getLLVMStyleWithColumns(15)));
+ format("a = f(/* long long */ a);", getLLVMStyleWithColumns(16)));
----------------
Please also leave the old test case, which is about the `*/` just going over
the column limit if not put on a newline.
================
Comment at: unittests/Format/FormatTestComments.cpp:2456
" */a);",
- getLLVMStyleWithColumns(15)));
+ getLLVMStyleWithColumns(16)));
----------------
Why change `15` to `16`? The same for the subsequent cases.
================
Comment at: unittests/Format/FormatTestComments.cpp:2481
" b);",
- format("a = f(a, /* long long */ b);", getLLVMStyleWithColumns(15)));
+ format("a = f(a, /* long long */ b);", getLLVMStyleWithColumns(16)));
----------------
Please also leave the old test case, which is about the `*/` just going over
the column limit if not put on a newline.
================
Comment at: unittests/Format/FormatTestComments.cpp:2488
" (1 + 1));",
- format("a = f(a, /* long long */ (1 + 1));",
getLLVMStyleWithColumns(15)));
+ format("a = f(a, /* long long */ (1 + 1));",
getLLVMStyleWithColumns(16)));
}
----------------
Please also leave the old test case, which is about the `*/` just going over
the column limit if not put on a newline.
https://reviews.llvm.org/D40068
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
