hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
LGTM with a few nits, I'd like to see whether @benhamilton has comments before committing it. ================ Comment at: docs/clang-tidy/checks/google-objc-avoid-throwing-exception.rst:4 +google-objc-avoid-throwing-exception +======================================= + ---------------- nit: remove the extra `===` ================ Comment at: docs/clang-tidy/checks/google-objc-avoid-throwing-exception.rst:10 +The corresponding style guide rule: +http://go/objc-style#Avoid_Throwing_Exceptions ---------------- Use the public link: http://google.github.io/styleguide/objcguide.html#avoid-throwing-exceptions ================ Comment at: test/clang-tidy/google-objc-avoid-throwing-exception.m:11 +@end + ---------------- nit: remove the empty line. https://reviews.llvm.org/D40058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
