ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.

Could you please take a different approach and add the callbacks you need into 
`PreambleCallbacks` class?
It already has this one:

  virtual void HandleMacroDefined(const Token &MacroNameTok,
                                 const MacroDirective *MD);

Otherwise we'll be creating too many ways to do the same thing.

We should also definitely get rid of all the unrelated formatting changes.


https://reviews.llvm.org/D39375



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D39375: [clang] Ad... Ilya Biryukov via Phabricator via cfe-commits

Reply via email to