Men-cotton wrote: @zayeralam, I understand that contributing to LLVM/ClangIR is exciting (I felt the same way when I started!). However, there is no need to rush this PR. Please take your time and revisit it when you next have access to your workstation.
Working out how to address review feedback is itself an important part of contributing. Rather than providing an exact patch for you to apply, I think it would be more valuable for you to make the changes yourself and use this as an opportunity to practice. Once you have updated the PR, I’ll be happy to review the result and answer any specific questions that remain. https://github.com/llvm/llvm-project/pull/217326 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
