skatrak wrote: > The tests in `Lower/AMDGPU` are all `-emit-llvm`. Is it possible to test with > `emit-hlfir`, or `emit-fir` instead? I ask because this looks related to the > [PR](https://github.com/llvm/llvm-project/pull/215536) that moves some tests > out of that directory.
I agree with this. As they are currently defined, these are integration (not lowering) tests, because they trigger multiple compiler stages. However, we should try to limit integration tests to anything that can't be tested otherwise. In this case, it seems like we might be able to give the same test coverage with `-emit-hlfir`. If not, these should be moved to the Integration subdirectory. https://github.com/llvm/llvm-project/pull/216751 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
