tberghammer added a comment.

In https://reviews.llvm.org/D39239#911696, @CarlosAlbertoEnciso wrote:

> Hi Tamas,
>
> Thanks very much for your message.
>
> In https://reviews.llvm.org/D39239#910797, @tberghammer wrote:
>
> > - Can you do a diff of the debug_info dump before and after your change? 
> > Understanding what have changed should give us a pretty good clue about the 
> > issue.
>
>
> For this specific case, the debug_info is the same before and after my 
> change, as the patch affects only unscoped enums.


If this patch doesn't effect the debug info generated for this specific case 
then my guess is that when LLDB builds the EnumDecl for the scoped enumeration 
it will incorrectly build one for an unscoped enum instead. Looking at the code 
at 
https://github.com/llvm-mirror/lldb/blob/master/source/Symbol/ClangASTContext.cpp#L2170
 we even have a TODO in the LLDB to fix handling for this case. Can you try out 
your patch with https://reviews.llvm.org/D39545 what supposed to fix the 
problem on the LLDB side (haven't tested it at all)?


https://reviews.llvm.org/D39239



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to