nathawes planned changes to this revision.
nathawes added a comment.

Thanks @arphaman! I'll work through your comments and update.



================
Comment at: include/clang/Index/IndexDataStoreSymbolUtils.h:13
+
+#include "indexstore/indexstore.h"
+#include "clang/Index/IndexSymbol.h"
----------------
arphaman wrote:
> It looks to me like this header, `"indexstore/indexstore.h"`, and 
> `IndexDataStoreUtils.cpp` are utilities just for the C API, so could we take 
> it out of here as well?
They're used by IndexRecordWriter below to convert from libIndex's 
representation of things to the index store's.


https://reviews.llvm.org/D39050



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to