aaron.ballman added a comment. In https://reviews.llvm.org/D39370#910803, @baloghadamsoftware wrote:
> In https://reviews.llvm.org/D39370#910791, @aaron.ballman wrote: > > > LGTM > > > > FYI: it's been difficult to perform this review because all of these > > reviews are touching the same chunk of code for something that's not been > > committed yet. It would be easier to review if all of these reviews were > > combined into the review adding the check. > > > I am also working for the Static Analyzer where I received the comment that > development should be incremental to avoid huge patches. So I tried to use > the same approach here as well. Incremental is definitely the way to go, but that's usually to prevent massive code dumps of large-scale functionality. For a single, relatively small check like this, I think it's fine to add all of this into one review because it's all so tightly related. https://reviews.llvm.org/D39370 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
