================

----------------
redstar wrote:

This fix is wrong. The ADA pointer is needed in this case to get the reference 
to the ED symbol.
The proper fix is to change in `SystemZAsmPrinter::emitEndOfAsmFile()` the 
condition to call `emitADA()` from
```
        if (!GV->hasInitializer())
```
to
```
        if (!GV->hasInitializer() || GV->hasCommonLinkage())
```
There may also be a change to `emitSymbolAttribute()` necessary in the same 
`if` part, I have not checked this.

https://github.com/llvm/llvm-project/pull/206833
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to