Sure, I’ll add a release note. The type for the -fno-short-wchar shouldn’t have changed on ARM. That sounds like a mistake. We could just promote the -fsigned-wchar to a driver level flag. Every target seems to use signed int, not unsigned int for wchar_t.
On Wed, Oct 25, 2017 at 1:32 PM Friedman, Eli <efrie...@codeaurora.org> wrote: > On 10/25/2017 12:49 PM, Reid Kleckner wrote: > > On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli <efrie...@codeaurora.org> > wrote: > >> Maybe we should just ignore -fno-short-wchar, instead? I think that's >> what gcc and released versions of clang do (that means -fno-short-wchar >> doesn't do anything for Windows targets, but that's probably fine). >> > > No, the intention of this change was to make -fno-short-wchar do something > on Windows targets. > > Really? I don't see any mention of that in either the patch itself, or in > the discussion of it. It's fine, I guess, but please add a note to the > release notes. > > -Eli > > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux > Foundation Collaborative Project > > -- Saleem Abdulrasool compnerd (at) compnerd (dot) org
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
