mstorsjo added inline comments.
================
Comment at: src/Registers.hpp:1342
}
+ static int lastDwarfRegNum() { return 287; }
----------------
mstorsjo wrote:
> compnerd wrote:
> > Can we not use `_LIBUNWIND_HIGHEST_DWARF_REGISTER` here?
> I guess we could - we could do that consistently throughout all the
> `Registers_*` classes then. Or even omit the method at all and just check
> `_LIBUNWIND_HIGHEST_DWARF_REGISTER` in the caller? Or perhaps the last part
> clashes with part of the (incomplete afaik?) intended design to support
> unwinding foreign systems as well.
This gets taken care of for the existing ones in D39281 - if that one goes
through I'll update this patch accordingly.
https://reviews.llvm.org/D39251
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
