sbc100 added inline comments.

================
Comment at: lib/Driver/ToolChain.cpp:318
+  else
+    OSLibName = getOS();
   llvm::sys::path::append(Path, "lib", OSLibName);
----------------
dschuff wrote:
> Is this logic intended to replace what was removed from CommonArgs.cpp? 
> Should there be an assert here too?
Just didn't see the point of that assert.  Can you see what the intention might 
be?  I don't see why AddRunTimeLibs() should be callable for any/all triples, 
do you?  I would have had to add  llvm::Triple::Unknown to the list of 
supported OSs, which seemed strange.


https://reviews.llvm.org/D39218



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to