ioeric added inline comments.
================ Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227 + SourceLocation EndLoc = Expr->hasExplicitTemplateArgs() + ? Expr->getLAngleLoc().getLocWithOffset(-1) + : Expr->getLocEnd(); ---------------- hokein wrote: > ioeric wrote: > > I wonder what would happen if we have `foo <int>()`? > There will be a blank left like `bar <int>();` if we don't format the apply > replacement, but I don't think this case really matters because we often > format the placements before applying them. Could you add a test for this? Thanks! https://reviews.llvm.org/D39120 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
