https://github.com/ilovepi approved this pull request.

This is quite a bit better. I've left mostly some nits. This can probably land 
when @evelez7 and @petrhosek approve. I'm still a bit concerned on the overall 
structure and design, but I think this will become easier to discuss as we move 
into parsing and using the data structures. I imagine there's still quite a bit 
of tweaking required before this is ready for any use outside of its own tests.

https://github.com/llvm/llvm-project/pull/205609
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to