uweigand wrote:

> @uweigand Would you mind taking a look and sharing your feedback? Thanks

The implementation looks fine - the only feedback I have is more higher-level: 
these new builtins seem to perform exactly the same operations that can already 
by achieved by the existing `__builtin_compare_exchange` and 
`__builtin_compare_exchange_n`  (among other options).    I understand that on 
z/OS, code may expect these new builtin names, but maybe this could have been 
achieved by defining them as macros or always-inline functions in some compiler 
or system header?

https://github.com/llvm/llvm-project/pull/202362
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to