Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: test/SemaOpenCL/vector_swizzle_length.cl:7 void foo() { - float8 f2 = (float8)(0, 0, 0, 0, 0, 0, 0, 0); + float8 f2 = (float8){0, 0, 0, 0, 0, 0, 0, 0}; ---------------- bruno wrote: > Anastasia wrote: > > Even though this works in Clang, ideally OpenCL vector literal is with > > parenthesis (see s6.1.6). > Ok. I changed this to avoid warnings in C mode. Gonna change it back, Can you undo this change please before committing. Thanks! https://reviews.llvm.org/D38868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits