https://github.com/timon-ul requested changes to this pull request.
Alright, so I have finally gotten around to give this a full review. Overall I think this looks good, the only thing I am a bit unsure about is you adding 6 new tests. Not saying I dislike you testing well, but I am wondering more about combining them into one or two tests, most of them have a large overlap in code and could easily be extended to contain multiple of the others (you can name code points too to have multiple). Would probably also be nice for speed. https://github.com/llvm/llvm-project/pull/199480 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
