jrtc27 wrote: > I don't have much experience with LLVM (apart from reporting bugs), but this > very simple PR has been waiting for over a month for merge: #198371. So I > didn't want this to be blocked until this seemingly low-profile PR gets > reviewed. The patch is very simple and the whole point was to make FreeBSD > CURRENT use IEEE binary128 for long double. Of course, I will create > necessary changes to address your feedback.
I don't know what your point is bringing up that other PR, but a lack of upstream reviewer engagement (noting that, as a FreeBSD and LLVM committer, I was not aware of either PR before today) does not justify not following proper procedure, especially when it comes to ABI transitions that require a lot of care to do right. https://github.com/llvm/llvm-project/pull/201298 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
