necto wrote:

> If you want relocatable PCHs, I'd suggest not storing the input file 
> modification times in the first place and at all and instead storing & 
> comparing the contents hash. Clang already has flags for this: 
> `-fno-pch-timestamp`, `-fvalidate-ast-input-files-content`.

This is what I ended up doing in the end. It introduces a slight overhead of 
computing and comparing file hashes, but it is acceptable in my use case. I 
still think it would make sense to ignore mtime for relocatable PCH, as this is 
what I expected based on the name of the property, but I don't want to keep an 
open PR, and I have a way forward without it.

https://github.com/llvm/llvm-project/pull/196057
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to