steakhal wrote: > > I think, ideally we had 2 commits (or PRs). One that does the NFC split, > > and the focused other patch for improving the diags. Mixing the two is bad > > practice. > > OK, I've split the PR into two commits. The first one improves diagnostics > and the second one splits the checker.
The problem is that llvm only allows squash-merges - consequently, it doesn't matter if you split things up into commits, because everything will get squashed anyway. My comment was about future changes. Just post two PRs next time. https://github.com/llvm/llvm-project/pull/201044 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
