https://github.com/usx95 requested changes to this pull request.

I think this can be done in a simpler way without introducing the private 
getters by using the PImpl pattern which LoanPropagation already used. Sorry 
about not advocating for the existing PImpl pattern earlier. I created 
https://github.com/llvm/llvm-project/pull/201071 for this. 

I would close this PR for now. If you feel otherwise, I am also fine closing 
mine and doing this here.

https://github.com/llvm/llvm-project/pull/201054
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to