ilya-biryukov added inline comments.
================
Comment at: clangd/GlobalCompilationDatabase.cpp:82
// FIXME(ibiryukov): Invalidate cached compilation databases on changes
+ return Result;
----------------
Why remove this `FIXME`?
================
Comment at: clangd/tool/ClangdMain.cpp:86
+ "The argument will be "
+ "ignored.\n";
+ CompileCommandsDirPath = llvm::None;
----------------
NIT: maybe join this with previous line?
================
Comment at: clangd/tool/ClangdMain.cpp:89
+ } else
+ CompileCommandsDirPath = CompileCommandsDir;
----------------
NIT: don't mix branches with and without `{}`. Simply use `{}` on all branches
in that case.
https://reviews.llvm.org/D37150
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
