llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/192044.diff 2 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp (+7-8) - (modified) clang-tools-extra/clang-tidy/misc/MisleadingBidirectionalCheck.cpp (+4-2) ``````````diff diff --git a/clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp index e0d4aa382d961..874664a959d2a 100644 --- a/clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp @@ -166,14 +166,13 @@ void RedundantBranchConditionCheck::check( CondOp->getRHS()->getBeginLoc().getLocWithOffset(-1); Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange( CondOp->getLHS()->getBeginLoc(), BeforeRHS)); - } else { - if (const auto NextToken = utils::lexer::findNextTokenSkippingComments( - CondOp->getLHS()->getEndLoc(), *Result.SourceManager, - getLangOpts())) { - const SourceLocation AfterLHS = NextToken->getLocation(); - Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange( - AfterLHS, CondOp->getRHS()->getEndLoc())); - } + } else if (const auto NextToken = + utils::lexer::findNextTokenSkippingComments( + CondOp->getLHS()->getEndLoc(), *Result.SourceManager, + getLangOpts())) { + const SourceLocation AfterLHS = NextToken->getLocation(); + Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange( + AfterLHS, CondOp->getRHS()->getEndLoc())); } } } diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingBidirectionalCheck.cpp b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectionalCheck.cpp index 9294c2b57e15e..894c6db8975f2 100644 --- a/clang-tools-extra/clang-tidy/misc/MisleadingBidirectionalCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectionalCheck.cpp @@ -66,16 +66,18 @@ static bool containsMisleadingBidi(StringRef Buffer, if (CodePoint == RLO || CodePoint == RLE || CodePoint == LRO || CodePoint == LRE) { BidiContexts.push_back(PDF); + } // Close PDF Context. - } else if (CodePoint == PDF) { + else if (CodePoint == PDF) { if (!BidiContexts.empty() && BidiContexts.back() == PDF) BidiContexts.pop_back(); } // Open a PDI Context. else if (CodePoint == RLI || CodePoint == LRI || CodePoint == FSI) { BidiContexts.push_back(PDI); + } // Close a PDI Context. - } else if (CodePoint == PDI) { + else if (CodePoint == PDI) { auto R = llvm::find(llvm::reverse(BidiContexts), PDI); if (R != BidiContexts.rend()) BidiContexts.resize(BidiContexts.rend() - R - 1); `````````` </details> https://github.com/llvm/llvm-project/pull/192044 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
