================
@@ -1,16 +1,28 @@
// RUN: %check_clang_tidy %s bugprone-unchecked-optional-access %t -- -- -I
%S/Inputs/unchecked-optional-access
#include "absl/types/optional.h"
-#include "folly/types/Optional.h"
-#include "bde/types/bsl_optional.h"
#include "bde/types/bdlb_nullablevalue.h"
+#include "bde/types/bsl_optional.h"
+#include "folly/types/Optional.h"
+#include "std/types/optional.h"
-void unchecked_value_access(const absl::optional<int> &opt) {
+void unchecked_value_access(std::optional<int> opt) {
opt.value();
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: unchecked access to optional
value [bugprone-unchecked-optional-access]
}
-void unchecked_deref_operator_access(const absl::optional<int> &opt) {
+void absl_unchecked_value_access(const absl::optional<int> &opt) {
+ opt.value();
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: unchecked access to optional
value
+ // [bugprone-unchecked-optional-access]
----------------
vbvictor wrote:
Can we place it on line above? Otherwise it isn't picked by and CHECK and
useless
https://github.com/llvm/llvm-project/pull/191681
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
