https://github.com/koparasy commented:
This is a fairly large PR. Thanks for putting it together. I’ve added a few comments inline. At a high level, I think we could align more closely with the original codegen path to reduce divergence and make the behavior easier to reason about. Also, for the lowering tests, it would be helpful to include the original LLVM-generated output as a reference. That way, reviewers can more easily compare and understand the differences. https://github.com/llvm/llvm-project/pull/181841 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
