================ @@ -12488,8 +12488,7 @@ static void diagnoseTautologicalComparison(Sema &S, SourceLocation Loc, QualType LHSType = LHS->getType(); QualType RHSType = RHS->getType(); if (LHSType->hasFloatingRepresentation() || - (LHSType->isBlockPointerType() && !BinaryOperator::isEqualityOp(Opc)) || - S.inTemplateInstantiation()) + (LHSType->isBlockPointerType() && !BinaryOperator::isEqualityOp(Opc))) ---------------- zyn0217 wrote:
This is incorrect, see our discussion in the issue. I think you should follow @Sirraide 's opinion and move the checking out of this function. https://github.com/llvm/llvm-project/pull/191101 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
