nathanchance wrote:
This change breaks `check-clang` with `LLVM_TOOL_LLVM_DRIVER_BUILD=ON` for me.
```
$ cmake \
-B build \
-G Ninja \
-S llvm \
-Wno-dev \
--log-level=NOTICE \
-DCLANG_ENABLE_STATIC_ANALYZER=OFF \
-DCLANG_PLUGIN_SUPPORT=OFF \
-DCMAKE_AR=$(command -v llvm-ar) \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_CXX_COMPILER=$(command -v clang++) \
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
-DCMAKE_C_COMPILER=$(command -v clang) \
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
-DCMAKE_RANLIB=$(command -v llvm-ranlib) \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DLLVM_ENABLE_BINDINGS=OFF \
-DLLVM_ENABLE_LIBXML2=OFF \
-DLLVM_ENABLE_OCAMLDOC=OFF \
-DLLVM_ENABLE_PROJECTS=clang \
-DLLVM_ENABLE_WARNINGS=OFF \
-DLLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR= \
-DLLVM_INCLUDE_DOCS=OFF \
-DLLVM_INCLUDE_EXAMPLES=OFF \
-DLLVM_LINK_LLVM_DYLIB=OFF \
-DLLVM_TARGETS_TO_BUILD=host \
-DLLVM_TOOL_LLVM_DRIVER_BUILD=ON \
-DLLVM_USE_LINKER=$(command -v ld.lld)
and ninja -C build check-clang
...
[3858/3859] Running the Clang regression tests
llvm-lit: /src/llvm/utils/lit/lit/llvm/config.py:569: note: using clang:
/build/bin/clang
llvm-lit: /src/llvm/utils/lit/lit/llvm/subst.py:130: note: Did not find cir-opt
in /build/bin:/build/bin
FAIL: Clang :: Driver/modules-driver-clang-modules-only.cpp (13624 of 24304)
******************** TEST 'Clang ::
Driver/modules-driver-clang-modules-only.cpp' FAILED ********************
Exit Code: 1
Command Output (stdout):
--
# RUN: at line 3
split-file /src/clang/test/Driver/modules-driver-clang-modules-only.cpp
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp
# executed command: split-file
/src/clang/test/Driver/modules-driver-clang-modules-only.cpp
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp
# RUN: at line 4
rm -rf
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/modules-cache
# executed command: rm -rf
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/modules-cache
# RUN: at line 6
/build/bin/clang -std=c++23 -fmodules-driver -Rmodules-driver -fmodules
-Rmodule-import
-fmodule-map-file=/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/module.modulemap
-fmodules-cache-path=/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/modules-cache
-fsyntax-only
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/main.cpp
2>&1 | sed 's:\\\\\?:/:g' | /build/bin/FileCheck
-DPREFIX=/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp
--check-prefix=CHECK-REMARKS
/src/clang/test/Driver/modules-driver-clang-modules-only.cpp
# executed command: /build/bin/clang -std=c++23 -fmodules-driver
-Rmodules-driver -fmodules -Rmodule-import
-fmodule-map-file=/src/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/module.modulemap
-fmodules-cache-path=/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/modules-cache
-fsyntax-only
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/main.cpp
# note: command had no output on stdout or stderr
# error: command failed with exit status: 1
# executed command: sed 's:\\\\\?:/:g'
# executed command: /build/bin/FileCheck
-DPREFIX=/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp
--check-prefix=CHECK-REMARKS
/src/clang/test/Driver/modules-driver-clang-modules-only.cpp
# .---command stderr------------
# | /src/clang/test/Driver/modules-driver-clang-modules-only.cpp:32:19: error:
CHECK-REMARKS: expected string not found in input
# | // CHECK-REMARKS: [[PREFIX]]/main.cpp:1:2: remark: importing module 'root'
from
# | ^
# | <stdin>:35:153: note: scanning from here
# | "transitive1-DDQRW7YXEZI3F36O72F5KEC5Y" [fillcolor=1, label="{ Module
type: Clang module | Module name: transitive1 | Hash: DDQRW7YXEZI3F36O72F5KEC5Y
}"];
# |
^
# | <stdin>:35:153: note: with "PREFIX" equal to
"/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp"
# | "transitive1-DDQRW7YXEZI3F36O72F5KEC5Y" [fillcolor=1, label="{ Module
type: Clang module | Module name: transitive1 | Hash: DDQRW7YXEZI3F36O72F5KEC5Y
}"];
# |
^
# | <stdin>:40:330: note: possible intended match here
# |
"/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/main.cpp-x86_64-unknown-linux-gnu"
[fillcolor=3, label="{ Filename:
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/main.cpp
| Triple: x86_64-unknown-linux-gnu }"];
# |
^
# |
# | Input file: <stdin>
# | Check file: /src/clang/test/Driver/modules-driver-clang-modules-only.cpp
# |
# | -dump-input=help explains the following input dump.
# |
# | Input was:
# | <<<<<<
# | .
# | .
# | .
# | 30: digraph "Module Dependency Graph" {
# | 31: rankdir="BT";
# | 32: label="Module Dependency Graph";
# | 33: node [shape=Mrecord, colorscheme=set23, style=filled];
# | 34:
# | 35: "transitive1-DDQRW7YXEZI3F36O72F5KEC5Y" [fillcolor=1,
label="{ Module type: Clang module | Module name: transitive1 | Hash:
DDQRW7YXEZI3F36O72F5KEC5Y }"];
# | check:32'0
X~~~ error: no match found
# | check:32'1
with "PREFIX" equal to
"/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp"
# | 36: "transitive2-886GFW0EED3NOOWKZ27DQF452" [fillcolor=1,
label="{ Module type: Clang module | Module name: transitive2 | Hash:
886GFW0EED3NOOWKZ27DQF452 }"];
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 37: "direct1-9X0WP2A3VQNHW8YIP6DQQVRF4" [fillcolor=1, label="{
Module type: Clang module | Module name: direct1 | Hash:
9X0WP2A3VQNHW8YIP6DQQVRF4 }"];
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 38: "direct2-D7KMK840PXAF30MYEN1YLQRIQ" [fillcolor=1, label="{
Module type: Clang module | Module name: direct2 | Hash:
D7KMK840PXAF30MYEN1YLQRIQ }"];
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 39: "root-58S8O8DO7YBAAKK6R8PR8Z6C2" [fillcolor=1, label="{
Module type: Clang module | Module name: root | Hash: 58S8O8DO7YBAAKK6R8PR8Z6C2
}"];
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 40:
"/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/main.cpp-x86_64-unknown-linux-gnu"
[fillcolor=3, label="{ Filename:
/build/tools/clang/test/Driver/Output/modules-driver-clang-modules-only.cpp.tmp/main.cpp
| Triple: x86_64-unknown-linux-gnu }"];
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | check:32'2
?
possible intended match
# | 41:
# | check:32'0 ~
# | 42: "transitive1-DDQRW7YXEZI3F36O72F5KEC5Y" ->
"direct1-9X0WP2A3VQNHW8YIP6DQQVRF4";
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 43: "transitive2-886GFW0EED3NOOWKZ27DQF452" ->
"direct1-9X0WP2A3VQNHW8YIP6DQQVRF4";
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 44: "transitive2-886GFW0EED3NOOWKZ27DQF452" ->
"direct2-D7KMK840PXAF30MYEN1YLQRIQ";
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 45: "direct1-9X0WP2A3VQNHW8YIP6DQQVRF4" ->
"root-58S8O8DO7YBAAKK6R8PR8Z6C2";
# | check:32'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | .
# | .
# | .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1
--
********************
********************
Failed Tests (1):
Clang :: Driver/modules-driver-clang-modules-only.cpp
...
```
https://github.com/llvm/llvm-project/pull/191258
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
