shafik wrote: @eiytoq please keeps notes to reviews as comments and don't put them in the PR summary. They can easily accidentally end up as part of the commit summary which is not really good. Your summary is what folks will see in the git log and that should contain:
- What the problem is - How you solve it - Any important considerations - GH issues reference Any misc comments that won't be relevant to someone reviewing git logs should go as a follow-up comment. https://github.com/llvm/llvm-project/pull/181068 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
