ojhunt wrote: > > > @nico This wasn't an intentional change, but it seems my code > > > modification has indeed caused some side effects. I suspect it might be > > > because my check on `hasLocalStorage()` was too aggressive. I'll fix it > > > as soon as I find the specific cause. > > > > > > Ah, that was a screw up on my part when reviewing. This should have been if > > `VD && !VD->hasLocalStorage()`. > > In addition to objc, we'll want to have test cases for instance and static > > fields in C and C++ records, and also possibly block and lambda captures of > > `__block` variables. > > Oh, I didn't even notice I added an extra exclamation mark (・_・;)
the check was written to avoid a null dereference, and it did do that, but it had the effect of of being overly permissive. @nico thanks for spotting this, and tracking this down as the cause https://github.com/llvm/llvm-project/pull/183988 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
