================
@@ -182,14 +190,13 @@ void FactsGenerator::VisitCXXConstructExpr(const
CXXConstructExpr *CCE) {
handleGSLPointerConstruction(CCE);
return;
}
- // Implicit copy/move constructors of lambda closures lack
- // [[clang::lifetimebound]], so `handleFunctionCall` cannot propagate
origins.
- // Handle them directly to keep the origin chain intact (e.g., `return
- // lambda;` copies the closure).
- if (const auto *RD = CCE->getType()->getAsCXXRecordDecl();
- RD && RD->isLambda() &&
- CCE->getConstructor()->isCopyOrMoveConstructor() &&
- CCE->getNumArgs() == 1) {
+ // For defaulted (implicit or `= default`) copy/move constructors, propagate
+ // origins directly. User-defined copy/move constructors have opaque
semantics
+ // and fall through to `handleFunctionCall`, where [[clang::lifetimebound]]
is
+ // needed to propagate origins.
+ if (CCE->getConstructor()->isCopyOrMoveConstructor() &&
+ CCE->getConstructor()->isDefaulted() && CCE->getNumArgs() == 1 &&
----------------
aeft wrote:
Yes. `copy_propagation` and the previous test `capture_int_by_value` (`return
lambda;` triggers copy).
`isDefaulted` covers both implicit and explicit.
https://github.com/llvm/llvm-project/blob/08a408500ed06297924823c5b8199b392e73d300/clang/include/clang/AST/Decl.h#L2425-L2431
https://github.com/llvm/llvm-project/pull/187917
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
