pcc wrote:

> This caused problems for top-level inline assembly where instructions require 
> a target feature. For example, in `global-inline-asm-flags.c` we have PACIB 
> and RETAB instructions that need a `+pauth` target flag. This test used to 
> fail with a diagnostic:

Won't this just push the same problem to link time? The linker won't 
necessarily know the correct target features for the inline asm.

It seems better to associate the target-cpu and target-features with the asm 
itself so that both the ModuleSymbolTable and the AsmPrinter know the correct 
features.

https://github.com/llvm/llvm-project/pull/174995
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to