https://github.com/owenca created https://github.com/llvm/llvm-project/pull/187842
Fixes #171841 >From 8f6dd4151b0551d1db633277a033335e4a39d93f Mon Sep 17 00:00:00 2001 From: Owen Pan <[email protected]> Date: Fri, 20 Mar 2026 22:24:03 -0700 Subject: [PATCH] [clang-format] Correctly annotate Java lambda/sychronized blocks Fixes #171841 --- clang/lib/Format/UnwrappedLineParser.cpp | 2 ++ clang/unittests/Format/TokenAnnotatorTest.cpp | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/clang/lib/Format/UnwrappedLineParser.cpp b/clang/lib/Format/UnwrappedLineParser.cpp index 08c962dd34bbb..a3e8a3e270e73 100644 --- a/clang/lib/Format/UnwrappedLineParser.cpp +++ b/clang/lib/Format/UnwrappedLineParser.cpp @@ -527,6 +527,8 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { // `) { }` can only occur in function or method declarations in JS. Tok->setBlockKind(BK_Block); } + } else if (Style.isJava() && PrevTok && PrevTok->is(tok::arrow)) { + Tok->setBlockKind(BK_Block); } else { Tok->setBlockKind(BK_Unknown); } diff --git a/clang/unittests/Format/TokenAnnotatorTest.cpp b/clang/unittests/Format/TokenAnnotatorTest.cpp index 4081b9c9b4994..756e97708cb8c 100644 --- a/clang/unittests/Format/TokenAnnotatorTest.cpp +++ b/clang/unittests/Format/TokenAnnotatorTest.cpp @@ -4040,6 +4040,18 @@ TEST_F(TokenAnnotatorTest, JavaRecord) { EXPECT_TOKEN(Tokens[6], tok::r_brace, TT_RecordRBrace); } +TEST_F(TokenAnnotatorTest, JavaSynchronizedBlock) { + auto Tokens = annotate("() -> {\n" + " synchronized { x; }\n" + "};", + getLLVMStyle(FormatStyle::LK_Java)); + ASSERT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_BRACE_KIND(Tokens[3], BK_Block); + EXPECT_BRACE_KIND(Tokens[5], BK_Block); + EXPECT_BRACE_KIND(Tokens[8], BK_Block); + EXPECT_BRACE_KIND(Tokens[9], BK_Block); +} + TEST_F(TokenAnnotatorTest, CppAltOperatorKeywords) { auto Tokens = annotate("a = b and c;"); ASSERT_EQ(Tokens.size(), 7u) << Tokens; _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
