================
@@ -188,6 +229,10 @@ void memset1_new_array() {
int *array = new int[10];
memset(array, 0, 10 * sizeof(int));
clang_analyzer_eval(array[2] == 0); // expected-warning{{TRUE}}
+ // FIXME: The analyzer should stop analysis after memset. Maybe the intent of
+ // this test was to test for this as a desired behaviour, but it shouldn't
be,
+ // going out-of-bounds with memset is a fatal error, even if we decide not to
+ // report it.
----------------
steakhal wrote:
Got it. Now I see what didn't parse for me.
`but it shouldn't be,` should end with a period instead of a comma.
The comma confused me and broke the flow of the sentence.
```suggestion
// FIXME: The analyzer should stop analysis after memset. Maybe the intent of
// this test was to test for this as a desired behaviour, but it shouldn't be.
// Going out-of-bounds with memset is a fatal error, even if we decide not to
// report it.
```
https://github.com/llvm/llvm-project/pull/186802
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
