quic-akaryaki wrote:

> > There are several reasons resource directory in needed. First, there are 
> > compiler-provided definition e.g. in stddef.h. Second, there declaration of 
> > target-specific intrinsics, like smmintrin.h for x86 and hexagon_protos.h 
> > for hexagon.
> 
> ok, if you are placing hexagon_* headers in resource dir, this looks fine but 
> you might want to run some tests before merging this, as now the builtin 
> headers are included before the C headers this means clang provided headers 
> (float.h, stddef.h) will be used instead of whatever libc was providing
> 
> I am sure there were some differences there which could break something

clang headers such as `<limits.h>`, `<stddef.h`, etc use `#include_next` so 
they should be included _before_ sysroot-provided headers. The x86 clang 
toolchain does this in teh same order. I'm not sure why linux-musl uses a 
reverse order, which I kept, but maybe we can remove this @androm3da ?

https://github.com/llvm/llvm-project/pull/186494
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to