EliaGeretto wrote:

> > > Thanks for putting up llvm/clang/lld together to make the full picture 
> > > clear, but when you are ready for a real review, ensure lld changes are 
> > > extracted to a separate patch.
> > 
> > 
> > @MaskRay I have three commits, one for lld, one for the clang Driver and 
> > one for llvm CodeGen. Is this ok or do you want me to break things up more?
> 
> Unfortunately this repo is configured to only allow ["Squash and 
> merge"](https://maskray.me/blog/2023-09-09-reflections-on-llvm-switch-to-github-pull-requests#commit-message).
>  The merged patch gets a single commit. In this case we do want separate 
> commits, which can only be achieved with multiple PRs.

Ah, I see, so you want me to create a new PR per commit and stack them with 
Graphite. I saw the guide, I'll do that. This is my first PR since the switch 
to GitHub, sorry about that.

https://github.com/llvm/llvm-project/pull/183275
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to