mizvekov wrote: > @mizvekov using SS.clear() and Previous.clear() stops the crash but it breaks > some existing tests i think the reason is that it runs for all qualified > friend definitions, including cases like friend void C::f() inside a class, > which should produce a different diagnostic so i am kinda thinking maybe the > recovery should run only when the qualifier refers to namespace/global scope, > which we can check using computeDeclContext(SS) will that would be a good > approach ? i think this should work
Ah yes, though that case is simpler to check, you don't need `computeDeclContext`, you can simply check for the right kinds of nested name specifier (namespace, namespace alias, and global). https://github.com/llvm/llvm-project/pull/186398 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
