================
@@ -3267,8 +3267,10 @@ void
CodeGenModule::createFunctionTypeMetadataForIcall(const FunctionDecl *FD,
void CodeGenModule::createCalleeTypeMetadataForIcall(const QualType &QT,
llvm::CallBase *CB) {
- // Only if needed for call graph section and only for indirect calls.
- if (!CodeGenOpts.CallGraphSection || !CB->isIndirectCall())
+ // Only if needed for call graph section and only for indirect calls that are
+ // visible externally.
+ if (!CodeGenOpts.CallGraphSection || !CB->isIndirectCall() ||
+ !isExternallyVisible(QT->getLinkage()))
----------------
ilovepi wrote:
Is this the right approach? I think we'd still want the metadata if its an
internal symbol... The test case is one I'd expect to work correctly, and I'm
surprised we've not hit this issue before.
https://github.com/llvm/llvm-project/pull/186272
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
