arphaman added inline comments.
================
Comment at: unittests/Tooling/RefactoringActionRulesTest.cpp:39
+ class Consumer final : public RefactoringResultConsumer {
+ void handleInitiationFailure() {
+ Result = Expected<Optional<AtomicChanges>>(None);
----------------
ioeric wrote:
> Can we probably have default error handling in the base class so that we
> don't need to re-implement these for every derived consumer. I would expect
> the error handling for initiation and invocation to be similar in different
> consumers.
I've merge the two error functions into one, but I'm reluctant to add default
implementation for them because of the reasons that I've mentioned in my
previous inline comment.
https://reviews.llvm.org/D37291
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
