NagyDonat wrote: > @NagyDonat Could you please take off this PR?
I can certainly try to do what I can, but unfortunately I don't think that my skills are adequate for a proper review of this change. I was vaguely following this review process for a long time and my impression was that this is a really useful patch, the code looks promising and I'm very happy that somebody else is working on it because I wouldn't be able to develop it myself :sweat_smile:. I tried to read the changes thoroughly, but my only fresh observation was that I spotted a trivial typo (highlighted in my "review"). I have also seen that there are several minor, mostly stylistic issues marked by @steakhal -- I completely agree with those suggestions and I think they should be rectified before merging this PR (but fixing them shouldn't be too difficult IMO). Apart from that, I agree that it is probably necessary to invite reviewers from the other affected areas. I'm not familiar with the people working on those areas, but if it helps, I could ping the code owners and/or the people who recently modified the affected areas (if any). @steakhal Should I do so? @vvuksanovic Overall the change looks very promising and I really hope that we can get it merged in the foreseeable future. https://github.com/llvm/llvm-project/pull/176126 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
